Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Correct hrefs for attachments in Standard Output (#153) #154

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

MJB222398
Copy link
Contributor

Please see (#153) this is a fix for that issue

Testing done

Ran the plugin locally and processed some test results, verified that the URLS in the hrefs are now correct and work as intended.

Submitter checklist

  • [ x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ x] Ensure that the pull request title represents the desired changelog entry
  • [ x] Please describe what you did
  • [ x] Link to relevant issues in GitHub or Jira
  • [ x] Link to relevant pull requests, esp. upstream and downstream changes
  • [ x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MJB222398 MJB222398 requested a review from a team as a code owner March 12, 2025 17:31
@jonesbusy
Copy link
Contributor

Please do not change the formatting. It's difficult to review if tab size are changed. Thanks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MJB222398
Copy link
Contributor Author

Please do not change the formatting. It's difficult to review if tab size are changed. Thanks

Sorry I was bumbling my way through Java and new IDEs. Have reverted the accidental whitespace

@jonesbusy
Copy link
Contributor

Maybe I'm missing something, but I don't observe same behavior

https://ci.jenkins.io/job/Tools/job/plugin-modernizer-tool/job/main/lastCompletedBuild/testReport/io.jenkins.tools.pluginmodernizer.cli/CommandLineITCase/linux_21___Build__linux_21____testCleanup/

Attachment is displayed correctly on both test and report page

@jonesbusy
Copy link
Contributor

Any thought @jenkinsci/junit-attachments-plugin-developers ?

@MJB222398
Copy link
Contributor Author

MJB222398 commented Mar 12, 2025

@jonesbusy I think you might be miss-reading the bug. I can see it reproduced in your example. This is about the hyperlinks in the Standard Output section. Not the links in the little 'Attachments' table

@jonesbusy
Copy link
Contributor

I see now. To be honest I never paid attention there was some hyperlink there.

@jonesbusy jonesbusy added the bug label Mar 12, 2025
@jonesbusy jonesbusy merged commit f662e91 into jenkinsci:main Mar 12, 2025
17 checks passed
@MJB222398
Copy link
Contributor Author

@jonesbusy Thanks for the quick turnaround! Yes it is very minor, but I noticed it during investigation into a more major issue (#156) and thought I might as well fix it. To see how this PR process works more than anything I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants