Modernization for JDK21 and JDK21 tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. As soon as I updated the parent POM, I got an error message stating I had to move to Jenkins version 2.361.x.
|
We're still using JDK8, and that's why the build is failing. |
MarkEWaite
suggested changes
Oct 9, 2023
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
|
@rsandell, @car-roll, or @dwnusbaum could you merge this so that the plugin is regularly tested with Java 21 and Java 17? |
MarkEWaite
approved these changes
Jan 2, 2024
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
jtnord
reviewed
Jan 3, 2024
jtnord
approved these changes
Jan 3, 2024
|
Thanks @jtnord ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with Java 21
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Testing done
I had to update the parent POM to get it to work with JDK21.
As soon as I did that, I had to change the Jenkins version, or it wouldn't compile.
Then I also changed the BOM version to be the same as the Jenkins version (as described in the "Improve a plugin tutorial").
Confirmed tests pass with Java 21.