Refresh plugin for June 2023 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Jun 23, 2023
| @@ -4,7 +4,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.54</version> | |||
| <version>4.67</version> | |||
There was a problem hiding this comment.
Latest version at the time of this writing.
| @@ -28,7 +28,7 @@ | |||
| </properties> | |||
|
|
|||
| <scm> | |||
| <connection>scm:git:git://github.com/${gitHubRepo}.git</connection> | |||
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | |||
There was a problem hiding this comment.
Adapting to the deprecation of the git:// protocol on GitHub.
| @@ -347,7 +347,7 @@ | |||
| <dependency> | |||
| <groupId>io.jenkins.tools.bom</groupId> | |||
| <artifactId>bom-2.375.x</artifactId> | |||
| <version>2102.v854b_fec19c92</version> | |||
| <version>2179.v0884e842b_859</version> | |||
There was a problem hiding this comment.
Latest version at the time of this writing.
| @@ -65,9 +65,8 @@ public class JiraCreateReleaseNotesTest { | |||
|
|
|||
| @Before | |||
| public void createCommonMocks() throws IOException, InterruptedException { | |||
| when(build.getProject()).thenReturn(project); | |||
There was a problem hiding this comment.
Fixing a Mockito warning about an unnecessary stub by removing the unnecessary stub.
| when(build.getEnvironment(buildListener)).thenReturn(env); | ||
| when(buildListener.fatalError(Mockito.anyString(), Mockito.any())).thenReturn(printWriter); | ||
| when(buildListener.fatalError(Mockito.anyString(), Mockito.any(Object[].class))).thenReturn(printWriter); |
There was a problem hiding this comment.
Adapting to the new Mockito 5 behavior for varargs.
| import com.gargoylesoftware.htmlunit.Page; | ||
| import com.gargoylesoftware.htmlunit.WebRequest; | ||
| import com.gargoylesoftware.htmlunit.util.NameValuePair; | ||
| import org.htmlunit.HttpMethod; |
There was a problem hiding this comment.
Adapting to the new HtmlUnit imports.
| @@ -172,6 +172,7 @@ public void comment() { | |||
| // mock build: | |||
| FreeStyleBuild build = mock(FreeStyleBuild.class); | |||
| FreeStyleProject project = mock(FreeStyleProject.class); | |||
| when(build.getParent()).thenReturn(project); | |||
There was a problem hiding this comment.
Adapting to a breaking change in Mockito.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #552. Tested with
mvn clean verifyon Java 17.