[JENKINS-72799] Apply SlaveComputer.decorate also to openLogFile
#9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Mar 2, 2024
comment-ops-bot
bot
added
the
ready-for-merge
jglick
added a commit
to jglick/support-core-plugin
that referenced
this pull request
Mar 5, 2024
jglick
added a commit
to jenkinsci/support-core-plugin
that referenced
this pull request
Mar 18, 2024
* agent-logs sketch * `SlaveLaunchLogsTest.onlineInboundAgent` * `SlaveLaunchLogsTest.offlineAgent` * Javadoc * Exploring `SlaveLaunchLogs` behavior * More `SlaveLaunchLogsTest` * `SlaveLaunchLogsTest.passwords` * Worked out a better `SlaveLaunchLogs`, but depends on patch to `SlaveComputer` * Need to flush logs also for `deletedAgent` * Reverting changes extracted to #518 * Setting a timestamp, switching category * RC * No need to assert that `SupportTestUtils.invokeComponentToString` is non-null * `Security2186Test` failure caused by renamed bundle entry * File handle leak caught by Windows tests * Better handling of rotated logs * More robust way to wait for `Connection terminated` message * `SlaveLaunchLogsTest.offlineAgent` still flaky on Windows * jenkinsci/jenkins#9009 released * Working around lack of JENKINS-72799 to avoid requiring a weekly core * SpotBugs --------- Co-authored-by: Allan Burdajewicz <aburdajewicz@cloudbees.com>
krisstern
pushed a commit
to krisstern/jenkins
that referenced
this pull request
Apr 2, 2024
…enkinsci#9009) (cherry picked from commit c7ccbfd)
krisstern
pushed a commit
to krisstern/jenkins
that referenced
this pull request
Apr 4, 2024
…enkinsci#9009) (cherry picked from commit c7ccbfd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-72799. Otherwise the decoration is applied to
SlaveComputer.taskListener, used for many purposes, but not log messages printed fromDefaultJnlpSlaveReceiveron inbound agents.Amending 4c43671 and ultimately 0ddb0c5.
Testing done
Integration test in jenkinsci/support-core-plugin#517:
SlaveLaunchLogsTest.onlineInboundAgent.Proposed changelog entries
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).