Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-71238] New login page breaks login-theme-plugin #8341

Merged
merged 1 commit into from Aug 8, 2023
Merged

[JENKINS-71238] New login page breaks login-theme-plugin #8341

merged 1 commit into from Aug 8, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Aug 6, 2023 •
edited by MarkEWaite

See JENKINS-71238.

This PR updates the login/register pages so that the 'header' element appears under the page title, as expected by its help text 'This HTML snippet will be inserted below the welcome message on the default login form'. Previously the text would appear on the left of the page.

Before (image from ticket)

After
image

I have left the 'head' element as is (as I'm assuming it's usage is just for <head /> tags).

Testing done

  • The login/register pages behave as before, but custom text in the 'header' element is now positioned correctly

Proposed changelog entries

  • New login page breaks login theme plugin.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@oleg-nenashev oleg-nenashev added the web-ui The PR includes WebUI changes which may need special expertise label Aug 6, 2023
@jonesbusy
Copy link
Contributor

If a fix in core is the way to go, any change it gets backported in next LTS ?

@NotMyFault NotMyFault added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases needs-security-review Awaiting review by a security team member labels Aug 6, 2023
@NotMyFault NotMyFault requested review from a team August 6, 2023 15:32
@NotMyFault
Copy link
Member

NotMyFault commented Aug 6, 2023 •
edited

If a fix in core is the way to go, any change it gets backported in next LTS ?

While 2.414.1 is possible, yet a bit short-termed, 2.414.2 onwards would definitely be viable.

@NotMyFault NotMyFault mentioned this pull request Aug 7, 2023
Closed
@NotMyFault NotMyFault added the ath-successful This PR has successfully passed the full acceptance-test-harness suite label Aug 7, 2023
NotMyFault
NotMyFault approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil changed the title [JENKINS-71238] New login page break login-theme-plugin [JENKINS-71238] New login page breaks login-theme-plugin Aug 7, 2023
yaroslavafenkin
yaroslavafenkin reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK security wise.

@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Aug 8, 2023
@MarkEWaite MarkEWaite merged commit 4ccb66b into jenkinsci:master Aug 8, 2023
17 checks passed
@timja timja deleted the JENKINS-71238-fix-login-theme branch August 8, 2023 12:25
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Sep 2, 2023
@janfaracik @krisstern
[JENKINS-71238] New login page breaks login-theme-plugin (jenkinsci…
5f47d53 
…#8341)

Move simple-header out

(cherry picked from commit 4ccb66b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavafenkin yaroslavafenkin yaroslavafenkin left review comments

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ath-successful This PR has successfully passed the full acceptance-test-harness suite regression-fix Pull request that fixes a regression in one of the previous Jenkins releases security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
7 participants
@janfaracik @jonesbusy @NotMyFault @oleg-nenashev @timja @yaroslavafenkin @MarkEWaite