Provide the means to customize the folder containing the java executable for RJR #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used to launch the JuT instead of delegating always to JAVA_HOME.
|
Coherent test issue, I will fix it |
car-roll
approved these changes
Nov 28, 2023
timja
approved these changes
Nov 28, 2023
| /** | ||
| * Allows to specify an alternate, not the one specified in JAVA_HOME, folder containing the JVM to use to launch the instance | ||
| */ | ||
| public RealJenkinsRule withAltJavaHome(String altJavaHome) { |
There was a problem hiding this comment.
is alt needed here? withJavaHome seems fine to me, and then the docs could be simplified I think.
(non blocking)
Suggested change
| public RealJenkinsRule withAltJavaHome(String altJavaHome) { | |
| public RealJenkinsRule withJavaHome(String altJavaHome) { |
There was a problem hiding this comment.
For me is an alternative one given the code assumes there is a default java home to use... However I understand is a matter so if there is other person (so 2 to 1) who wants to change I will
There was a problem hiding this comment.
withJavaHome seems more natural to me as well, with a mention that it defaults to java.home sysprop.
|
Can I get this merged, please? It seems no more feedback is coming and this is already approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to launch the JuT using any JVM instead of always delegating to JAVA_HOME.
Useful due to the upcoming support process for different JVM versions as it would allow to create RJR test configurations that share the same code but run with different JVMs, like 17 and 21
Testing done
Manual tested by creating a test that uses a custom location on my local system.
There are unit tests that ensures the new code works as expected also.
Submitter checklist