Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of Commons Lang 3 #614

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jun 23, 2023

As a prerequisite to #550, remove usages of Commons Lang 3 from this repository. Although Commons Lang 3 was part of a public API, in practice no consumers existed other than a class in a different package in this repository itself (thankfully). In any case, the use of a tuple in the return type was unnecessary — the Server object has a reference to the ServletContext which can be fished out by any consumers that need it.

Testing done

Ran Text Finder plugin tests with this PR.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@basil basil added the internal label Jun 23, 2023
@basil basil requested review from jglick and Vlatombe June 23, 2023 15:49
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basil basil enabled auto-merge (squash) June 23, 2023 16:06
@basil basil merged commit 6490cb4 into jenkinsci:master Jun 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants