Improve the case where the Jenkins process stopped unexpectedly #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was printing a stacktrace with Connection refused (Connection refused) This now prints the exit code.
timja
approved these changes
Jun 22, 2023
jglick
reviewed
Jun 26, 2023
| try { | ||
| endpoint("exit").openStream().close(); | ||
| } catch (ConnectException e) { | ||
| System.err.println("Unable to connect to the Jenkins process to stop it."); |
There was a problem hiding this comment.
I guess a stack trace is uninteresting here?
There was a problem hiding this comment.
We'll get a stacktrace from the assertion error just below if it happens.
There was a problem hiding this comment.
I meant the stack trace from the ConnectException. Really only the detail message could possibly be interesting.
| @Test public void killedExternally() throws Throwable { | ||
| rr.startJenkins(); | ||
| try { | ||
| rr.proc.destroy(); |
There was a problem hiding this comment.
Or I suppose it would work to runRemotely something that asynchronously calls Jenkins.exit?
There was a problem hiding this comment.
Yes, though exit code wouldn't be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was printing a stacktrace with Connection refused (Connection refused)
This now prints the exit code.
Testing done
Submitter checklist