Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize CSSErrorHandler#ignore in HudsonTestCase with the primary version in JenkinsRule #611

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jun 14, 2023

This PR does not attempt to solve JENKINS-14749 (which I think was solved but regressed at some point), but it does synchronize the code in HudsonTestCase with that in JenkinsRule by favoring the version in JenkinsRule and applying that to HudsonTestCase. Once synchronized in this PR, the two versions should be kept in sync going forward.

Testing done

Will rely on the CI build.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@basil basil added the internal label Jun 14, 2023
@basil basil merged commit f258a61 into jenkinsci:master Jun 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants