Replace hamcrest matchers with methods from non-deprecated packages #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
changed the title
Can you give an example of a method whose signature has changed? |
|
Methods now return Matchers.doSth instead of CoreMatchers.doSth |
|
In which method is a return value of |
|
Adjusted the labels, the underlying hamcrest methods return the same. Looks like I read it wrong before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #587 in mind, we can make use of the methods from the
hamcrestpackage, which is the drop-in replacement for the deprecated -core package.The code from the deprecated package has been merged in, and the methods return the same, nonetheless I applied the
breakinglabel because the method signature changes.Testing with core in jenkinsci/jenkins#8046 revealed no issues.