Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauled RunLoadCounter #583

Merged
merged 1 commit into from
May 16, 2023
Merged

Overhauled RunLoadCounter #583

merged 1 commit into from
May 16, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented May 15, 2023

  • Availability of TransientActionFactory obviates the need for prepare.
  • Current project/count fields were ThreadLocal which made it impossible to test the effects of Queue.maintain.
  • Negative currCount logic was hard to follow and blocked clearer logging.

@jglick jglick added the bug label May 15, 2023
@jglick jglick requested review from Vlatombe and a team May 15, 2023 15:02
jglick added a commit to jglick/workflow-job-plugin that referenced this pull request May 15, 2023
jglick added a commit to jglick/jenkins that referenced this pull request May 15, 2023
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jglick jglick merged commit 0555c10 into jenkinsci:master May 16, 2023
13 checks passed
@jglick jglick deleted the RunLoadCounter branch May 16, 2023 12:36
jglick added a commit to jglick/jenkins that referenced this pull request May 16, 2023
@basil
Copy link
Member

basil commented Jun 8, 2023

jglick added a commit to MarkEWaite/pipeline-model-definition-plugin that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants