Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for InboundAgentRule to be online as part of starting it #577

Merged
merged 6 commits into from
May 10, 2023
Merged

Wait for InboundAgentRule to be online as part of starting it #577

merged 6 commits into from
May 10, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented May 8, 2023

No description provided.

@jglick jglick requested a review from Vlatombe May 9, 2023 17:03
@jglick
Copy link
Member Author

jglick commented May 10, 2023

Ran all core tests using InboundAgentRule against this (merged with master) just to be sure. Note that https://github.com/jenkinsci/jenkins/blob/fd90fdf17f62e90d31ae21843c8f86e2f976a1ac/test/src/test/java/jenkins/slaves/restarter/JnlpSlaveRestarterInstallerTest.java#L67-L72 is not currently using the start option.

@jglick
Copy link
Member Author

jglick commented May 10, 2023

Just noticed that start(JenkinsRule, …) is not using the same logic, which I guess it should be. Let me try that…

@jglick
Copy link
Member Author

jglick commented May 10, 2023

not currently using the start option

Ah, start defaults to true.

@jglick jglick requested a review from Vlatombe May 10, 2023 13:55
@jglick jglick merged commit 8a5a6cf into jenkinsci:master May 10, 2023
13 checks passed
@jglick jglick deleted the InboundAgentRule-waitOnline branch May 10, 2023 19:10
@jglick jglick mentioned this pull request May 15, 2023
Merged
This was referenced May 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil left review comments

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jglick @basil @Vlatombe