Require Java 11 and Jenkins 2.361.4 or newer #96
Conversation
VignanMudedla
commented
Apr 12, 2023
•
VignanMudedla
commented
- updated parent pom to 4.59(allow compilation with java 11)
- updated base Jenkins version to 2.361.4
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
-updated parent pom to 4.59 -updated base jenkins version to 2.362.4
|
Hey @MarkEWaite! Can you help we with the windows-8 build fail. I'll be more than happy if any one could help me with this |
|
It needs two more steps:
|
|
Hey @MarkEWaite is this good?
can I add another new configuration for windows-17? |
Because the test configurations incur a cost, we increase test configurations only when we believe that the additional configuration will give useful information for the many times that it will be run (each pull request runs the Pipeline, master branch runs the Pipeline, etc.) The "Improve a plugin" tutorial chooses only two configurations because that felt like the best balance between information and cost. One of the configurations is Linux and one is Windows because Windows and Linux have some very important differences. One of the configurations is Java 11 and one is Java 17 because there are some interesting differences between those two. So long as we touch each of those key differences in at least one configuration, that gives us most of the benefit without the cost of testing all combinations of the configurations. We're using pairwise testing in the Jenkinsfile to cover the most important cases without needing to perform exhaustive testing of all combinations Short answer, I recommend against adding a separate test of Java 17 with Windows so long as Windows is tested in at least one configuration and Java 17 is tested in at least one configuration. |
replaced java 8 with java 11 and java 17
…b.com/VignanMudedla/javadoc-plugin into update-parent-pom-and-jenkins-version
|
Hey @MarkEWaite I've updated Jenkinsfile to java 11 and java 17 but Jenkins CI is yet building for java 8. build failed again. sorry, I'm pinging you for little things but I really need some help |
A change to the Jenkinsfile is one of those things that requires a ping of someone else unless you are a maintainer of the plugin. I'll start a build of the plugin with your modified Jenkinsfile so that you can see the results. |
update Jenkins version to 2.387.2 Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
|
Hey @MarkEWaite Thanks a lot for your support!! |
remove windows java 11 build config Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
There was a problem hiding this comment.
I have confirmed that the changes to the Jenkinsfile run as expected in a recent job. I had missed two items in previous reviews. Included in this review.
I've been reviewing proposed changes from @VignanMudedla and see that there is only one person in the https://github.com/orgs/jenkinsci/teams/javadoc-plugin-developers group (Kohsuke). My adoption of the plugin will focus on merging pull requests from VignanMudedla and from dependabot, including: * jenkinsci/javadoc-plugin#96 - update base Jenkins version * jenkinsci/javadoc-plugin#97 - more spotbugs checks * jenkinsci/javadoc-plugin#94 - dependabot I'll also close the following outdated dependabot pull request: * jenkinsci/javadoc-plugin#93
added build config for windows java 17 Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
changed the title
There was a problem hiding this comment.
Still needs the bom-2.361.x change and the latest bom version in that change. When you resolve a comment, I assume it means you addressed the concern, but in this case, the concern was not addressed. Let's get more benefits from the Java 11 transition, not just update the minimum Jenkins version.
…b.com/VignanMudedla/javadoc-plugin into update-parent-pom-and-jenkins-version
I just committed that change!! |
Delighted that you're willing to learn and very happy to have your contribution. Thanks again. Once this change is merged I have two more changes that I will push through, then the plugin will release so that you can see the results of your efforts in a plugin release. |
