Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Prototype.js with native JavaScript #297

Merged
merged 1 commit into from
May 23, 2023

Conversation

basil
Copy link
Member

@basil basil commented May 12, 2023

See JENKINS-70906. Jenkins core currently uses Prototype 1.7, released on November 15, 2010. The latest version is Prototype 1.7.3, released on September 22, 2015. When an attempt was made to upgrade to 1.7.3 in 2018 in JENKINS-49319, the change had to be reverted. Since this library has been unmaintained for the past 8 years, this PR removes any usages of it in favor of native JavaScript APIs. I tested a very similar change successfully in the context of jenkinsci/ant-plugin#121.

@welandaz
Copy link
Member

Hi @basil!
Thanks a lot for the PR!

Have you also tested the change with our plugin? (similarly to what you've mentioned here). Just to make sure everything works as before and we didn't break anything.

@basil
Copy link
Member Author

basil commented May 12, 2023

I have not.

@alextu
Copy link
Contributor

alextu commented May 23, 2023

I've tested it locally, it works fine, thanks for your contribution !

@alextu alextu merged commit 15ed186 into jenkinsci:master May 23, 2023
@basil basil deleted the remove-prototype branch May 23, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants