Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 2.479.1 or newer #18

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Require 2.479.1 or newer #18

merged 1 commit into from
Mar 12, 2025

Conversation

basil
Copy link
Member

@basil basil commented Feb 25, 2025

No description provided.

@basil basil added the internal Maintenance for the repository label Feb 25, 2025
@basil basil requested a review from a team February 25, 2025 19:02
@l3ender
Copy link
Contributor

l3ender commented Feb 26, 2025

Thanks for the PR!

Could you please update the description about why this change is being made and/or what problem is being solved?

@basil
Copy link
Member Author

basil commented Feb 26, 2025

@l3ender This is needed for plugin compatibility testing (PCT) against newer cores. PCT is currently working against plugin parent POM 4.x only with a lot of ugly workarounds for EE 8 (embedded in plugin parent POM 4.x) which we hope to remove in jenkinsci/plugin-compat-tester#753 once all plugins have been released with plugin parent POM 5.x (hence this PR).

@basil basil requested a review from l3ender February 27, 2025 20:10
@basil
Copy link
Member Author

basil commented Mar 11, 2025

Hi @l3ender, this plugin is now the last remaining plugin blocking us from moving forward with jenkinsci/plugin-compat-tester#753 in jenkinsci/bom. Can this PR please be merged and released?

Copy link
Contributor

@l3ender l3ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test, so hoping the changes are good. 😉

@l3ender l3ender merged commit 8ef8318 into jenkinsci:master Mar 12, 2025
17 checks passed
@basil basil deleted the refresh branch March 12, 2025 01:42
@basil
Copy link
Member Author

basil commented Mar 12, 2025

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants