Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explicit dark-theme colors #11

Merged
merged 1 commit into from
Feb 2, 2025
Merged

remove explicit dark-theme colors #11

merged 1 commit into from
Feb 2, 2025

Conversation

mawinter69
Copy link
Contributor

do not define explicit colors for dark-theme. Use background and text color instead which are defined for normal and dark theme with well working values.

fixes #6

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sorry, something went wrong.

do not define explicit colors for dark-theme. Use background and text
color instead which are defined for normal and dark theme with well
working values.

fixes #6
@mawinter69 mawinter69 requested a review from a team as a code owner February 2, 2025 03:12
@mawinter69 mawinter69 added the bug For changelog: Minor bug. Will be listed after features label Feb 2, 2025
@mawinter69 mawinter69 merged commit f6e5343 into main Feb 2, 2025
16 checks passed
@mawinter69 mawinter69 deleted the fix-css branch February 10, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover colors not working on MacOS with dark theme on chrome
1 participant