Revive test suite on Windows #331
Conversation
|
The test Harness seems to assume that Docker on Windows only runs Linux containers while our VM agents, today, are only providing Windows containers on Windows VMs. So it errors with a message such as It also fails for the @jtnord did already open an issue to request having a Docker Engine able to run Linux containers on Windows agents: jenkins-infra/helpdesk#3548 => Is this a case we want to support with this plugin? It would mean supporting Windows agents with Docker Desktop on them, running in "Linux mode" (which is the default case for developer Windows machines with WSL usually, but is it for Jenkins agents?) |
|
@dduportal I actually just added to support checking the docker OS mode as a necessity in this in a PR I pushed up here. See #332 |
basil
force-pushed
the
windows
branch
2 times, most recently
from
275847b to
9ef5e52
Compare
Co-authored-by: Mark <MarkRx@users.noreply.github.com>
The plugin BOM agents seem to have the `docker` command available but the user running the agent is not authorized to use the `docker` command. Previously that was detected by calling `docker ps` and detecting the failure. Restores a change made in * jenkinsci#331 Testing done Confirmed that I could see the same failure on a local computer as is seen on https://ci.jenkins.io/job/Tools/job/bom/job/master/3968/testReport/org.jenkinsci.plugins.docker.workflow/DockerDSLTest/ The computer had Docker CE installed by the specific user running the test did not have permission to access Docker. Prior to this change, the tests failed with the message: CANNOT CONNECT TO THE DOCKER DAEMON AT UNIX:///VAR/RUN/DOCKER.SOCK. IS THE DOCKER DAEMON RUNNING? After making this change, the tests pass on that computer with the specific user that does not have permission to access Docker.
The plugin BOM agents seem to have the `docker` command available but the user running the agent is not authorized to use the `docker` command. Previously that was detected by calling `docker ps` and detecting the failure. Restores a change made in * #331 Testing done Confirmed that I could see the same failure on a local computer as is seen on https://ci.jenkins.io/job/Tools/job/bom/job/master/3968/testReport/org.jenkinsci.plugins.docker.workflow/DockerDSLTest/ The computer had Docker CE installed by the specific user running the test did not have permission to access Docker. Prior to this change, the tests failed with the message: CANNOT CONNECT TO THE DOCKER DAEMON AT UNIX:///VAR/RUN/DOCKER.SOCK. IS THE DOCKER DAEMON RUNNING? After making this change, the tests pass on that computer with the specific user that does not have permission to access Docker.
No description provided.