Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 2.452.4 and fix test compilation #327

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

jonesbusy
Copy link
Contributor

Due to the FormException, quick fix is to add a static block

Also update Jenkins to match archetype (expect the custom label)

Testing done

Just compile. Will rely on CI for tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
reta Andriy Redko
@jonesbusy jonesbusy force-pushed the plugin-modernizer-tool branch from f98afdd to 6d6c30d Compare January 12, 2025 05:43
@jonesbusy
Copy link
Contributor Author

Bumping also remoting since 4.10 doesn't work anymore with core version https://github.com/jenkinsci/jenkins/blob/jenkins-2.452.4/pom.xml#L91

@basil basil merged commit 1ee556b into jenkinsci:master Jan 17, 2025
1 of 3 checks passed
@basil basil added the internal label Jan 17, 2025
@basil
Copy link
Member

basil commented Jan 17, 2025

@jonesbusy I'm getting some failures on the main branch after merging this PR: https://ci.jenkins.io/job/Plugins/job/docker-workflow-plugin/job/master/124/

@jonesbusy jonesbusy deleted the plugin-modernizer-tool branch January 17, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants