Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent POM, update dependencies, test with Java 21 #26

Merged
merged 7 commits into from Jan 11, 2024

Conversation

gounthar
Copy link
Contributor

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21 on Linux.

Supersedes pull request: #16.
Supersedes pull request: #21.
Supersedes pull request: #23.
Supersedes pull request: #25
.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Copy link
Contributor

@olivergondza , @marco-miller, or @michael1010 could you review and merge this? We've announced support for Java 21 with Jenkins 2.426.1 and we like to have most of the 250 most popular plugins testing with Java 21 and Java 17. This is one of the few plugin sin the 250 most popular plugins that is not already testing with Java 21.

No need for a release. The merge to the primary branch is sufficient.

@marco-miller
Copy link
Member

@olivergondza , @marco-miller, or @michael1010 could you review and merge this? We've announced support for Java 21 with Jenkins 2.426.1 and we like to have most of the 250 most popular plugins testing with Java 21 and Java 17. This is one of the few plugin sin the 250 most popular plugins that is not already testing with Java 21.

No need for a release. The merge to the primary branch is sufficient.

I've been inactive on projects such as this one for many years already; sorry.

MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Jan 11, 2024
jenkinsci/description-setter-plugin#26 (comment)
is a comment from Marco Miller that indicates he's been inactive on
projects for many years.  Rather than including as a maintainer, let's
ackonwledge that he's no longer maintaining those plugins.

@marco-miller, I'd appreciate a "+1" or another comment indicating that
you approve this change.
@MarkEWaite
Copy link
Contributor

Thanks for the reply @marco-miller . I've submitted a pull request to remove you as a maintainer of the two plugins where you are a listed maintainer. Could you comment on the pull request that you're OK with that change:

MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Jan 11, 2024
I'm a user of this plugin and there is only one listed maintainer
currently.

jenkinsci/description-setter-plugin#26 is the
pull request that I plan to merge.  I don't plan to make major changes
to the plugin, only merge that pull request and assure that the
backlog of maintenance pull requests (like dependabot) are handled at
least once a month.

I'll probably modernize the plugin to move the documentation to the
GitHub repository and take other steps from the "Improve a plugin"
tutorial.  No commitment, but because I use the plugin, I will tend to
improve the plugin so that the maintenance is simpler.
@MarkEWaite MarkEWaite merged commit f9905bd into jenkinsci:master Jan 11, 2024
13 checks passed
@gounthar gounthar deleted the jdk21 branch January 11, 2024 16:41
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
4 participants