Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to select from already uploaded icons #158

Closed
HeikoNardmann opened this issue Mar 24, 2023 · 5 comments · Fixed by #160
Closed

unable to select from already uploaded icons #158

HeikoNardmann opened this issue Mar 24, 2023 · 5 comments · Fixed by #160
Assignees
Labels
enhancement New feature or request

Comments

@HeikoNardmann
Copy link

HeikoNardmann commented Mar 24, 2023

What feature do you want to see added?

After uploading a custom icon from my disk the icon for the current folder gets set. But what if I want to use the same icon again for some other folder? I don't see a way to browse and select an already uploaded icon?

Or am I missing something?

Upstream changes

No response

@HeikoNardmann HeikoNardmann added the enhancement New feature or request label Mar 24, 2023
@strangelookingnerd
Copy link
Contributor

@HeikoNardmann Thanks for your suggestion!

Currently this would only be possible by uploading the image again for each folder. I see that this can become a bit cumbersome when you have a larger number of folders. However an „image gallery“ is not something that would already be included in Jenkins UI libs so I need to figure something out and see if it is doable or feasible.

@strangelookingnerd strangelookingnerd self-assigned this Mar 24, 2023
@strangelookingnerd strangelookingnerd linked a pull request Mar 25, 2023 that will close this issue
5 tasks
strangelookingnerd added a commit that referenced this issue Mar 29, 2023
Show already uploaded icons and make them selectable.
An ItemListener was added to automatically delete unused icons when the folder is deleted.
@strangelookingnerd
Copy link
Contributor

Issue resolved and released with 2.6

@HeikoNardmann
Copy link
Author

Hey, I didn't expect this improvement within the next half year!!! Great! 😃
Hopefully I'll find time on Friday to try this.
Thanks a lot!

@HeikoNardmann
Copy link
Author

Today I've updated the update information. Now the new version is listed. One problem: you now state that Jenkins 2.397 is the minimum. Is this high version number really required? I just have the 2.375.4 LTS and therefore are unable to install this update.

@strangelookingnerd
Copy link
Contributor

Release 2.6 that includes this feature does require Jenkins latest LTS 2.387.1 due to some changes in the Jenkins Core it depends on.
The release notes state the currently latest tested version for this plugin is Jenkins 2.397 - but again, this is not a requirement but only for my test. Maybe I should change the merge commit message for future updates to be a little clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants