[JENKINS-72364] Close provider dialog window when cancel is clicked #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One change from jenkinsci#491 was applied to a reference that was not using Prototype.js. https://issues.jenkins.io/browse/JENKINS-72364 is the issue report. Confirmed interactively that I can see the problem before the change and that with this change the problem is resolved.
rsandell
approved these changes
Dec 7, 2023
jtnord
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-72364 Close provider dialog window when cancel is clicked
One change from #491 was applied to a reference that was not using Prototype.js.
Testing done
Confirmed interactively that I can see the problem before the change and that with this change the problem is resolved.
No test automation created due to the high effort to create the test and low long term value of the test.
Submitter checklist
I'd prefer to have a review from @rsandell , @raul-arabaolaza, @yaroslavafenkin, or @ampuscas