Prepare for prototype removal #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
raul-arabaolaza
approved these changes
Oct 24, 2023
… prototype_removal
rsandell
requested review from
raul-arabaolaza,
basil,
car-roll,
julieheard,
yaroslavafenkin,
BorisYaoA and
ampuscas
raul-arabaolaza
approved these changes
Oct 24, 2023
|
I have tested it: When I start Jenkins and take into account this PR, there are no errors, and I can create a new domain and add credentials, without any errors |
ampuscas
approved these changes
Oct 25, 2023
|
I've reverted the changes to |
ampuscas
approved these changes
Oct 25, 2023
raul-arabaolaza
approved these changes
Oct 26, 2023
yaroslavafenkin
approved these changes
Oct 26, 2023
|
Potentially introduced JENKINS-72364 |
basil
reviewed
Nov 28, 2023
| @@ -3,5 +3,5 @@ Behaviour.specify("#credentials-add-submit", 'credentials-dialog-add', 0, functi | |||
| }); | |||
|
|
|||
| Behaviour.specify("#credentials-add-abort", 'credentials-dialog-abort', 0, function (e) { | |||
| e.onclick = (_) => window.credentials.dialog.hide(); | |||
| e.onclick = (_) => window.credentials.dialog.style.display = "none"; | |||
There was a problem hiding this comment.
This change appears to be in error, as this was YUI code, not Prototype code.
MarkEWaite
added a commit
to MarkEWaite/credentials-plugin
that referenced
this pull request
Dec 7, 2023
One change from jenkinsci#491 was applied to a reference that was not using Prototype.js. https://issues.jenkins.io/browse/JENKINS-72364 is the issue report. Confirmed interactively that I can see the problem before the change and that with this change the problem is resolved.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.jenkins.io/blog/2023/05/12/removing-prototype-from-jenkins/
Testing done
Manual testing done:
Submitter checklist