[JENKINS-52386] Add preview for markup of a CredentialParameterDefinition #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflect description name attribute update
microscotch
force-pushed
the
bugfix/credentials-parameter-does-not-support-HTML-in-description
branch
from
984594c
to
e49e6ca
Compare
|
@Wadeck @daniel-beck (can't add reviewers, so mentioning you here) |
daniel-beck
reviewed
Jan 30, 2023
...main/resources/com/cloudbees/plugins/credentials/CredentialsParameterDefinition/config.jelly
Outdated
Show resolved
Hide resolved
…lsParameterDefinition/config.jelly Apply suggestion Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
daniel-beck
reviewed
Jan 31, 2023
src/test/java/com/cloudbees/plugins/credentials/CredentialsParameterDefinitionTest.java
Outdated
Show resolved
Hide resolved
…escription' of https://github.com/microscotch/jenkins-credentials-plugin into bugfix/credentials-parameter-does-not-support-HTML-in-description
daniel-beck
reviewed
Feb 7, 2023
src/test/java/com/cloudbees/plugins/credentials/CredentialsParameterDefinitionTest.java
Outdated
Show resolved
Hide resolved
daniel-beck
approved these changes
Feb 7, 2023
|
Hi @raul-arabaolaza, Any chance to get this PR merged ? |
|
Hi @daniel-beck, What's missing to get this PR merged into master branch ? Did I miss something in the process ? |
jtnord
changed the title
jtnord
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing markup formater for CredentialParameterDefinition to fix [JENKINS-52386] - credentials() parameter does not support HTML in description