Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric and style customization of trend charts #338

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Add metric and style customization of trend charts #338

merged 4 commits into from
Feb 24, 2025
+610 −210

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 21, 2025 •
edited
Loading

Update trend chart implementations to allow metric visibility customization by the user. Improve separation of coverage and metrics handling. Introduce a configuration system for charts with support for lines vs. filled areas.

Tasks:

  • Add configuration for trend charts on job page
  • Add configuration for trend charts on details page

Bildschirmfoto 2025-02-21 um 16 22 15
Bildschirmfoto 2025-02-21 um 16 22 00

Sorry, something went wrong.

@uhafner uhafner added the feature New features label Feb 21, 2025
@uhafner uhafner changed the title Add metric customization and refactor trend chart logic Add metric and style customization of trend charts Feb 21, 2025
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 300 passed, 🙈 7 skipped)
   〰️   Line Coverage: 76% (725 missed lines)
   ➰   Branch Coverage: 66% (290 missed branches)
   CheckStyle   CheckStyle: 1 warning (normal: 1)
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🌀   Cyclomatic Complexity: 954 (total)
   💭   Cognitive Complexity: 563 (total)
   📏   Lines of Code: 11368 (total)
   📝   Non Commenting Source Statements: 4015 (total)
   🔭   Access to foreign data: 545 (total)
   🔗   Class cohesion: 100.00% (maximum)
   📤   Fan out: 1455 (total)
   📲   Number of accessors: 152 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 1180 (total)
   ➿   N-Path Complexity: 1566 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@uhafner
Add metric customization and refactor trend chart logic
Loading
Loading status checks…
60a4b2f 
Update trend chart implementations to allow metric
visibility customization by the user.
Improve separation of coverage and metrics handling.
Introduce a configuration system for charts with support
for lines vs. filled areas.
@uhafner uhafner marked this pull request as draft February 21, 2025 18:26
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 300 passed, 🙈 7 skipped)
   〰️   Line Coverage: 76% (725 missed lines)
   ➰   Branch Coverage: 66% (290 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🌀   Cyclomatic Complexity: 954 (total)
   💭   Cognitive Complexity: 563 (total)
   📏   Lines of Code: 11375 (total)
   📝   Non Commenting Source Statements: 4015 (total)
   🔭   Access to foreign data: 545 (total)
   🔗   Class cohesion: 100.00% (maximum)
   📤   Fan out: 1455 (total)
   📲   Number of accessors: 152 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 1180 (total)
   ➿   N-Path Complexity: 1566 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@uhafner
Add configuration of trend charts
Loading
Loading status checks…
251be8e 
Now metric and coverage charts can be customized. Users can decide
whether the charts are using a lines or stacked lines chart.
Additionally, the visible metrics for each chart can be selected.
@uhafner
Remove obsolete method
Loading
Loading status checks…
10b82a6
@uhafner uhafner marked this pull request as ready for review February 24, 2025 20:54
@uhafner
Simplify the series builders
Loading
Loading status checks…
ecebb0a 
Since the series are filtered by the user now we do not need
to generate different series for coverage and software metrics.
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 300 passed, 🙈 7 skipped)
   〰️   Line Coverage: 76% (735 missed lines)
   ➰   Branch Coverage: 66% (288 missed branches)
   CheckStyle   CheckStyle: 1 warning (normal: 1)
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🌀   Cyclomatic Complexity: 958 (total)
   💭   Cognitive Complexity: 560 (total)
   📏   Lines of Code: 11405 (total)
   📝   Non Commenting Source Statements: 4012 (total)
   🔭   Access to foreign data: 542 (total)
   🔗   Class cohesion: 100.00% (maximum)
   📤   Fan out: 1470 (total)
   📲   Number of accessors: 152 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 1183 (total)
   ➿   N-Path Complexity: 1569 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 300 passed, 🙈 7 skipped)
   〰️   Line Coverage: 76% (730 missed lines)
   ➰   Branch Coverage: 66% (288 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🌀   Cyclomatic Complexity: 957 (total)
   💭   Cognitive Complexity: 560 (total)
   📏   Lines of Code: 11395 (total)
   📝   Non Commenting Source Statements: 4009 (total)
   🔭   Access to foreign data: 542 (total)
   🔗   Class cohesion: 100.00% (maximum)
   📤   Fan out: 1460 (total)
   📲   Number of accessors: 152 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 1182 (total)
   ➿   N-Path Complexity: 1568 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit 8a289c9 into main Feb 24, 2025
21 of 29 checks passed
@uhafner uhafner deleted the metrics-trend branch February 24, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@uhafner