Revert "Bump maven-plugin from 3.16 to 3.21" #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkinsci/bom#1978 notes that the upgrade of the optional dependency on the maven plugin from 3.16 to 3.21 caused the Jenkins plugin bill of materials to need an explicit inclusion of the Jenkins maven plugin into the plugin BOM. That's not a desired change because the Jenkins maven plugin tests do not pass when run in the Jenkins plugin BOM test suites. We don't want to invest the effort in the Jenkins maven plugin tests to make them work in the Jenkins plugin BOM. The #174 dependabot proposed upgrade is being reverted to avoid the problem. When dependabot next proposes an upgrade of this dependency, it can be closed or evaluated as an incremental build in the Jenkins plugin BOM before the upgrade is approved.
allancth
approved these changes
Apr 21, 2023
|
@MarkEWaite The commands to dependabot to squash and merge seems to have no effect. Shall I merge this? |
This isn’t a dependabot PR but yes please merge |
allancth
deleted the
revert-174-dependabot/maven/org.jenkins-ci.main-maven-plugin-3.21
branch
|
@timja Squashed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #174
See discussion in jenkinsci/bom#1978 for the detailed motivation for this change.
It is generally good to upgrade dependencies, but in this case, the upgraded dependency complicates the Jenkins plugin bill of materials. Rather than complicate something that is widely used in the Jenkins project, let's intentionally retain this optional dependency at its older version.
This pull request is ready for review because the incremental build of the pull request evaluated successfully in the Jenkins plugin bill of materials. @allancth, once this is merged, it will generate a new release.