Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71414] Add DataBoundConstructor and Symbol to FolderConfigFileProperty #277

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Jun 8, 2023

…r overload

  • Added DataboundConstructor to the FolderConfigFileProperty
  • Added symbol folderConfigFile to the property descriptor
  • Remove owner overload that is un-necessary
  • Deprecated constructor

Testing done

  • Spin up Jenkins
  • Create a Folder
  • Add Folder config files
  • Save

--> Validate the the config files are still there after save
--> Validate the the config files are still there after restart

  • create a pipeline job in the folder:

    node {
        configFileProvider([configFile(fileId: '<fileID>, targetLocation: 'test.txt', variable: 'TEST')]) {
          sh "cat $TEST"
        }
    }
    
  • Run the pipeline

--> Validate that it properly injects the file and the content is expected

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh requested a review from a team as a code owner June 8, 2023 02:33
@alecharp alecharp changed the title [JENKINS-71414] Add DataboundConstructor and remove un-necessary owne… [JENKINS-71414] Compatibility with configuration-as-code Jun 8, 2023
@alecharp
Copy link
Member

alecharp commented Jun 8, 2023

Would it be possible to test this automatically?

@rsandell
Copy link
Member

Last time I checked JCasC didn't support creating folders and other Items, so the title isn't really correct.

Co-authored-by: Robert Sandell <rsandell@cloudbees.com>
@Dohbedoh Dohbedoh changed the title [JENKINS-71414] Compatibility with configuration-as-code [JENKINS-71414] Add DataBoundConstructor and Symbol to FolderConfigFileProperty Jun 19, 2023
Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved just don't merge this yet.Other things in the pipeline that needs to go in first.

@rsandell rsandell merged commit 4a88b78 into jenkinsci:master Jul 11, 2023
14 checks passed
@Dohbedoh Dohbedoh deleted the JENKINS-71414 branch July 24, 2023 21:53
car-roll pushed a commit to car-roll/config-file-provider-plugin that referenced this pull request Jul 24, 2023
…leProperty (jenkinsci#277)

Co-authored-by: Robert Sandell <rsandell@cloudbees.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants