Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #276

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

timja-bot
Copy link
Contributor

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot requested a review from a team as a code owner June 5, 2023 11:42
@alecharp
Copy link
Member

alecharp commented Jun 5, 2023

@timja FYI, your migration script my not be perfect, see #276 (comment)

@timja
Copy link
Member

timja commented Jun 5, 2023

@timja FYI, your migration script my not be perfect, see #276 (comment)

Yes the description has what can’t be handled currently

@timja timja requested a review from alecharp June 5, 2023 17:21
@alecharp
Copy link
Member

alecharp commented Jun 5, 2023

I'm the last pusher but the build is not passing.
I'm merging this. Do you need a release @timja?

@alecharp alecharp merged commit f79366f into jenkinsci:master Jun 5, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants