Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore script-security updates #2817

Merged
merged 4 commits into from Jan 8, 2024
Merged

Restore script-security updates #2817

merged 4 commits into from Jan 8, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 8, 2024

@jglick jglick requested a review from a team as a code owner January 8, 2024 15:41
MarkEWaite
MarkEWaite approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the bug Something isn't working label Jan 8, 2024
@jglick
Copy link
Member Author

jglick commented Jan 8, 2024

https://ci.jenkins.io/job/Tools/job/bom/job/PR-2817/3/testReport/org.jenkinsci.plugins.scriptsecurity.scripts/ScriptApprovalLoadingTest/pct_script_security_plugin_weekly___dynamicLoading/ skipped as expected

@jglick jglick enabled auto-merge (squash) January 8, 2024 17:30
@MarkEWaite
Copy link
Contributor

https://ci.jenkins.io/job/Tools/job/bom/job/PR-2817/3/testReport/org.jenkinsci.plugins.scriptsecurity.scripts/ScriptApprovalLoadingTest/pct_script_security_plugin_weekly___dynamicLoading/ skipped as expected

I'm pre-emptively merging this because there was a weekly-test that has already evaluated all these tests from the master branch. No reason to waste the money to run another full weekly test when the specific fix has been confirmed by Jesse's review of the CI job.

@MarkEWaite MarkEWaite merged commit dd1c81e into jenkinsci:master Jan 8, 2024
164 of 166 checks passed
@jglick jglick deleted the script-security branch January 8, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@Vlatombe Vlatombe Vlatombe approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug Something isn't working weekly-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the script-security 1310.vf24a_dfce068b_ block
4 participants
@jglick @MarkEWaite @Vlatombe @timja