Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ASM API plugin on bom #2810

Merged
merged 1 commit into from Jan 7, 2024
Merged

Conversation

jonesbusy
Copy link
Contributor

See https://groups.google.com/g/jenkinsci-dev/c/NhV_o6zxbzw for full context

Testing done

PLUGINS=asm-api TEST=InjectedTest bash local-test.sh

As the ASM dependencies are provided by core for now there is probably no need to perform any more test.

But including the plugin on bom will allow us to prepare direct or transitive (like jenkinsci/json-path-api-plugin#12) consumer before ASM is actually removed from core

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@jonesbusy jonesbusy requested a review from a team as a code owner January 7, 2024 15:35
@timja timja added the enhancement New feature or request label Jan 7, 2024
@timja timja merged commit 3668726 into jenkinsci:master Jan 7, 2024
5 checks passed
@jonesbusy jonesbusy deleted the feature/asm-plugin branch January 7, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants