Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude dependency updates to google-oauth-plugin 1.1.1 #2574

Merged
merged 2 commits into from Oct 10, 2023
Merged

Exclude dependency updates to google-oauth-plugin 1.1.1 #2574

merged 2 commits into from Oct 10, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 9, 2023 •
edited

Exclude dependency updates to google-oauth-plugin 1.1.1

Plugin breaks tests of other plugins

Rework is in progress.

#2563 updated the google oauth plugin to 1.1.1 and broke tests in google-storage-plugin and the google-compute-engine-plugin.

#2567 reverted it again

#2572 incremented it again

Let's stop the pattern of new commit followed by a revert

Testing done

No testing done. Dependency exclusions need to be tested by dependabot.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@MarkEWaite
Exclude dependency updates to google-oauth-plugin 1.1.1
a22d5d1 
Plugin breaks tests of other plugins

Rework is in progress.

jenkinsci#2563 updated the google oauth
plugin to 1.1.1 and broke tests in google-storage-plugin and the
google-compute-engine-plugin.

jenkinsci#2567 reverted it again

jenkinsci#2572 incremented it again

Let's stop the pattern of new commit followed by a revert
@MarkEWaite
Return to google-oauth-plugin 1.0.11
d2e3042 
Causes test failures in google-storage-plugin and google-compute-plugin
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 9, 2023 23:57
basil
basil approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just revert the update, trigger dependabot, and remove auto-merge with a blocking review to stop it from updating the dependency again.

@MarkEWaite MarkEWaite enabled auto-merge (squash) October 10, 2023 00:01
@MarkEWaite MarkEWaite merged commit faf0ae3 into jenkinsci:master Oct 10, 2023
4 of 5 checks passed
@basil
Copy link
Member

basil commented Oct 10, 2023

I guess the format of the name should have been org.jenkins-ci.plugins:google-oauth-plugin.

@MarkEWaite MarkEWaite deleted the exclude-google-oauth-plugin-1.1.1 branch October 11, 2023 16:27
@MarkEWaite MarkEWaite mentioned this pull request Nov 22, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkEWaite @basil