Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump org.jenkins-ci.plugins:google-oauth-plugin from 1.0.11 to 1.1.1 in /bom-weekly" #2567

Conversation

MarkEWaite
Copy link
Contributor

Reverts #2563 because the updated google oath plugin causes test failures in the google storage plugin and the google compute engine plugin. Needs more investigation and likely needs a new release of the google oauth plugin

@MarkEWaite MarkEWaite added the bug Something isn't working label Oct 6, 2023
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 6, 2023 12:52
@MarkEWaite MarkEWaite enabled auto-merge (squash) October 6, 2023 12:57
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 8e4540d into master Oct 6, 2023
4 of 6 checks passed
@MarkEWaite MarkEWaite deleted the revert-2563-dependabot/maven/bom-weekly/org.jenkins-ci.plugins-google-oauth-plugin-1.1.1 branch October 6, 2023 13:04
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Oct 9, 2023
Plugin breaks tests of other plugins

Rework is in progress.

jenkinsci#2563 updated the google oauth
plugin to 1.1.1 and broke tests in google-storage-plugin and the
google-compute-engine-plugin.

jenkinsci#2567 reverted it again

jenkinsci#2572 incremented it again

Let's stop the pattern of new commit followed by a revert
MarkEWaite added a commit that referenced this pull request Oct 10, 2023
* Exclude dependency updates to google-oauth-plugin 1.1.1

Plugin breaks tests of other plugins

Rework is in progress.

#2563 updated the google oauth
plugin to 1.1.1 and broke tests in google-storage-plugin and the
google-compute-engine-plugin.

#2567 reverted it again

#2572 incremented it again

Let's stop the pattern of new commit followed by a revert

* Return to google-oauth-plugin 1.0.11

Causes test failures in google-storage-plugin and google-compute-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants