Revert checks-api from 2.0.1 to 2.0.0 #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
added
the
full-test
|
Or just send a PR to checks-api? |
I'd love to do that but I don't think that I have the maven skills to resolve the issue in checks-api plugin and analysis-pom-plugin as described at jenkinsci/checks-api-plugin#233 (comment) . Based on the recommendation from Basil, I think that I would need to remove commons-lang3-api from analysis pom and add it to each of the pom files that consume the analysis pom. |
The most recent release of the credentials-binding plugin adds masking for base64 credentials. That's a nice improvement. Unfortunately, it causes one of the config-file-provider tests to fail. Adapt older bom profiles to "Bump credentials-binding (jenkinsci#2509)" by retaining the current version of the credentials binding plugin on the weekly release and pinning the previous credentials binding plugin release on the LTS releases. Could exclude the test failure on all releases, but it seemed better to be able to detect test failures from the weekly release even if we can't yet test the new version with the LTS releases. This partially reverts commit bab8257.
…enkinsci#2471)" jenkinsci#2484 describes the unexpected addition of commons-text-api as a new dependency for many consumers of the plugin bill of materials. Rather than having more and more plugins adding dependencies on the commons-text-api or the commons-lang3-api plugin, let's keep the checks-api dependency at 2.0.0 instead of 2.0.1. jenkinsci/checks-api-plugin#233 is the issue reported to the checks-api plugin. Once that issue is resolved, we should be able to use more recent checks-api plugin versions. Dependency updates that had to add commons-text-api included: * jenkinsci/bitbucket-kubernetes-credentials-plugin#133 * jenkinsci/elastic-axis-plugin#309 * jenkinsci/nodelabelparameter-plugin#265 * jenkinsci/testng-plugin-plugin#244 This reverts commit 729dfb2.
MarkEWaite
force-pushed
the
revert-checks-api-2.0.1-upgrade
branch
from
d206659
to
25a3381
Compare
6 tasks
|
Release is blocked by an authentication issue in the GitHub action that performs the release. Build passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert checks-api from 2.0.1 to 2.0.0
#2484 describes the unexpected addition of commons-text-api as a new dependency for many consumers of the plugin bill of materials.
Rather than having more and more plugins adding dependencies on the commons-text-api or the commons-lang3-api plugin, let's keep the checks-api dependency at 2.0.0 instead of 2.0.1.
jenkinsci/checks-api-plugin#233 is the issue reported to the checks-api plugin. Once that issue is resolved, we should be able to use more recent checks-api plugin versions.
Dependency updates that had to add commons-text-api included:
This reverts commit 729dfb2.
Testing done
PLUGINS=checks-api bash local-tests.sh passes
Submitter checklist