Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blue Ocean to the managed set #2308

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jul 31, 2023

No description provided.

@basil basil added work-in-progress full-test Test all LTS lines in this PR and do not halt upon first error. labels Jul 31, 2023
<dependency>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>favorite</artifactId>
<!-- TODO https://github.com/jenkinsci/favorite-plugin/pull/129 -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on the release of this

@jtnord
Copy link
Member

jtnord commented Aug 1, 2023

Why would you want to consider this?

  • BlueOcean has long been deprecated, builds do not work on modern ARM platforms or windows.
  • The interesting pars of BO are written in javascript and are not tested as part of the PCT.
  • BlueOcean itself is not extensible, so depending on it in a plugin is questionable.

@MarkEWaite
Copy link
Contributor

Why would you want to consider this?

When @basil and I discussed it, he noted that by placing blue ocean into the plugin bill of materials we can detect issues earlier. The benefit was focused more on early detection of issues than on assisting other plugins with managing their dependencies.

@basil
Copy link
Member Author

basil commented Aug 1, 2023

@basil basil marked this pull request as ready for review August 7, 2023 04:50
@basil basil requested a review from a team as a code owner August 7, 2023 04:50
@timja timja merged commit b4ed97b into jenkinsci:master Aug 7, 2023
526 checks passed
@jglick jglick added the enhancement New feature or request label Aug 7, 2023
basil added a commit to basil/bom that referenced this pull request Aug 8, 2023
@basil basil deleted the blueocean branch August 9, 2023 02:09
@basil
Copy link
Member Author

basil commented Aug 9, 2023

This change is already proving valuable, as I have found a bug in a different project that I would not have discovered had I not been running PCT against Blue Ocean from day 1

@MarkEWaite
Copy link
Contributor

I would like to release a new version of the plugin bill of materials mid-week this week, rather than wait until the end of the week. The new release would include the addition of the blue ocean plugins, the maven plugin, and the conditional build step plugin. Several useful updates have also arrived since the previous release.

Does that work for you @basil ? Any compelling reason for me to wait until end of the week to do the release?

@basil
Copy link
Member Author

basil commented Aug 9, 2023

Sure, sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants