chore(pipeline) switch to dedicated agent resources #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
timja
approved these changes
Apr 29, 2023
|
Merging as the expected outcome is present:
But the expected goal is there: no more competition with the normal node pool |
jglick
reviewed
May 1, 2023
| timeout(120) { | ||
| sh 'mvn -version' | ||
| // Exclude DigitalOcean artifact caching proxy provider, currently unreliable on BOM builds | ||
| // TODO: remove when https://github.com/jenkins-infra/helpdesk/issues/3481 is fixed |
Comment on lines
+15
to
+18
| withEnv(["JAVA_HOME=/opt/jdk-$params.jdk"]) { | ||
| infra.withArtifactCachingProxy { | ||
| withEnv([ | ||
| "MAVEN_ARGS=${env.MAVEN_ARGS != null ? MAVEN_ARGS : ''} -B -ntp -Dmaven.repo.local=${WORKSPACE_TMP}/m2repo" |
There was a problem hiding this comment.
Slightly clearer and more efficient to combine the two withEnv steps.
There was a problem hiding this comment.
Good catch, thanks for the post review!
Opened #2033 for this one
Comment on lines
+101
to
+103
| sh ''' | ||
| mvn -v | ||
| bash pct.sh |
dduportal
added a commit
that referenced
this pull request
May 2, 2023
6 tasks
jglick
added a commit
to jglick/bom
that referenced
this pull request
May 3, 2023
MarkEWaite
pushed a commit
that referenced
this pull request
May 3, 2023
* Skip PCT by default on PRs * Run full tests weekly * Empty commit should suffice * `git branch -D` might be necessary Co-authored-by: Joseph Petersen <me@jetersen.dev> * Copying DB automerge workflow from #2031 * Revert #2032 for `prep` phase, retaining node pool for PCT #2034 (comment) --------- Co-authored-by: Joseph Petersen <me@jetersen.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is motivated by jenkins-infra/helpdesk#3521.
This PR switches to a set of resources dedciated to the BOM, to avoid blocking other plugins/projects builds on ci.jenkins.io.
Unlike the experiments in #1969, there is no change in the VM or agent sizing to deliver one change at a time.
Please note there are 2 minors changes in this PR:
mvn -vSH steps into the principal steps[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue