-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plugin from 4.61 to 4.62 in /sample-plugin #2029
Bump plugin from 4.61 to 4.62 in /sample-plugin #2029
Conversation
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.61 to 4.62. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.61...plugin-4.62) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot squash and merge
I thought that there might be a problem with this pull request handling the tests from the GitLab plugin. The pull request fails in CI because the GitLab plugin depends on My assumption appears to be wrong because the GitLab plugin tests pass when I run this pull request from my desktop with the command:
I assume that is because the GitLab plugin tests are run with plugin pom 4.61 (or earlier) as defined in the release of the GitLab plugin rather than being run with plugin pom 4.62 as defined in this pull request. Clearly I have more to learn about the plugin BOM... |
Correct. PCT reruns tests after updating core & plugin deps. Everything else (e.g., |
Out of curiosity, why? Changes to |
It was the first item that I saw that seemed like a good excuse to label in order to generate a release. It had been almost a week since the previous releases and I wanted an item that I could use to label a pull request in order to be able to generate a release. I'm happy to use any other item if there is a preference for other items. |
OK. FYI, you can also trigger a release explicitly, despite none of the labels being “interesting” (see #2031 (review)); and note that as of #1993 at least some manual action is now required. |
Bumps plugin from 4.61 to 4.62.
Release notes
Sourced from plugin's releases.
Commits
210e74d
[maven-release-plugin] prepare release plugin-4.629502105
Upgrade fromjavax.servlet-api-3.1
tojakarta.servlet-api:4.0
and ban jav...5f8c1b8
Remove file-based Spotless activation (#747)21d03e9
Bump mockito-bom from 5.3.0 to 5.3.1 (#746)47fb8a6
[maven-release-plugin] prepare for next development iterationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @jglick.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)