Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Launchable group names #2020

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Apr 27, 2023

It turns out that Launchable group names can't contain slashes. I was using group names of e.g. jenkinsci/text-finder-plugin which Launchable rejects when recording test results. This should fix the problem by defining the group name as e.g. text-finder-plugin.

@basil
Copy link
Member Author

basil commented Apr 28, 2023

Seems to be working fine:

[2023-04-28T01:09:10.890Z] + launchable/bin/launchable record tests --session builds/jenkins-Tools-bom-PR-2020-2-weekly/test_sessions/1901564 --group popper2-api-plugin maven './**/target/surefire-reports' './**/target/failsafe-reports'
[2023-04-28T01:09:11.515Z] No matches found: ./**/target/surefire-reports

@basil basil marked this pull request as ready for review April 28, 2023 01:21
@MarkEWaite MarkEWaite merged commit e36cc00 into jenkinsci:master Apr 28, 2023
164 of 165 checks passed
@basil basil deleted the launchable-group branch April 28, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants