Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pct-work/ inside target/ #2008

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Move pct-work/ inside target/ #2008

merged 1 commit into from
Apr 27, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 27, 2023

Fixes #1996. I guess; using target/pct-work/ for simplicity since there is no remaining reason for target/local-test/ to exist. No explanation was given for why this directory location would be significant, or to whom. GitHub search turns up nothing. All I can guess is that it is desired for mvn clean to delete unversioned files. (git clean -fdx will not suffice otherwise, though git clean -ffdx would.)

@jglick jglick added the chore Reduces future maintenance label Apr 27, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will appreciate being able to run mvn clean again like I was able to before.

@jglick jglick enabled auto-merge (squash) April 27, 2023 20:36
@MarkEWaite MarkEWaite merged commit 30faa21 into jenkinsci:master Apr 27, 2023
2 of 3 checks passed
@MarkEWaite
Copy link
Contributor

Build had progressed far enough to confirm the changes were working. Merged.

@jglick jglick deleted the pct-work branch April 27, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pct-work not in expected location
3 participants