Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream Spotless configuration for pom.xml files #1998

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 22, 2023

For consistency with other repositories in the Jenkins project and the configuration used by the Maven developers themselves, this removes the <nrOfIndentSpace>4</nrOfIndentSpace> customization from this repository and reformats all pom.xml files to have 2 spaces rather than 4. This should be reviewed with the "hide whitespace changes" GitHub feature to see the substance of this change. This seems like a good time to do this because there are not any Dependabot PRs currently open, so the risk of conflict is low.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good timing for the change.

@timja timja added the chore Reduces future maintenance label Apr 22, 2023
@timja timja merged commit a004eba into jenkinsci:master Apr 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants