Upgrade PCT; Launchable improvements #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
launchable
branch
2 times, most recently
from
fee30b1
to
c4a906e
Compare
basil
commented
Apr 22, 2023
Comment on lines
+34
to
+43
| @NonCPS | ||
| def parsePlugins(plugins) { | ||
| def pluginsByRepository = [:] | ||
| plugins.each { plugin -> | ||
| def splits = plugin.split('\t') | ||
| pluginsByRepository[splits[0]] = splits[1].split(',') | ||
| } | ||
| pluginsByRepository | ||
| } | ||
|
|
There was a problem hiding this comment.
The new format of the file is group/repository\tplugin1,plugin2,plugin3. This parsing function is marked @NonCPS for performance reasons, as serializing each line to disk for a 200-line list would be inefficient.
| launchable("record build --name \"${BUILD_TAG}-${line}\" --no-commit-collection " + commitHashes) | ||
| launchable("record session --build \"${BUILD_TAG}-${line}\" --observation >launchable-session-${line}.txt") | ||
| stash name: "launchable-session-${line}.txt", includes: "launchable-session-${line}.txt" | ||
| launchable("record build --name ${env.BUILD_TAG}-${line} --no-commit-collection " + commitHashes + " --link \"View build in CI\"=${env.BUILD_URL}") |
There was a problem hiding this comment.
Cosmetic fix: adding a link back to Jenkins to make it easier to view this information in the Launchable UI.
| pluginsByRepository.each { plugins -> | ||
| branches["pct-$plugins-$line"] = { | ||
| pluginsByRepository.each { repository, plugins -> | ||
| branches["pct-$repository-$line"] = { |
There was a problem hiding this comment.
The cosmetic fix to the branch view: showing the repository name rather than the list of plugins in the UI.
|
|
||
| def jdk = line == 'weekly' ? 17 : 11 | ||
| def sessionFile = "launchable-session-${line}.txt" | ||
| launchable("record session --build ${env.BUILD_TAG}-${line} --flavor platform=linux --flavor jdk=${jdk} --observation --link \"View session in CI\"=${env.BUILD_URL} >${sessionFile}") |
There was a problem hiding this comment.
Adding the platform and JDK as flavors to be consistent with our general use of Launchable flavors in core and ATH builds.
MarkEWaite
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to jenkinsci/plugin-compat-tester#536 by using the repository name to improve the display of the Pipeline stage view steps as well as passing this information to Launchable as the group name for Launchable zero-input subsetting. I tested this with a passing CI build with these changes (using my admin powers to replay the build with the
Jenkinsfilechanges).