Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream Spotless configuration where it does not conflict with our own #1980

Merged
merged 1 commit into from Apr 19, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 19, 2023

This PR should eliminate some of the maintenance burden associated with this repository by using upstream Spotless configuration wherever it does not conflict with our own. We still retain some of our own configuration, like configuration for Groovy files (which I intend to eventually move upstream) and the 4-space indentation for pom.xml files (which could be easily removed if the maintainers are willing to tolerate some merge conflicts with Dependabot PRs).

@basil
Copy link
Member Author

basil commented Apr 19, 2023

(Note: this is fine to merge as long as the prep.sh stage passes; there is no need to wait for hundreds of plugin tests to pass to validate this change.)

@MarkEWaite MarkEWaite merged commit 1dc4fa0 into jenkinsci:master Apr 19, 2023
238 checks passed
@jglick jglick added the chore Reduces future maintenance label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants