Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update CLI #1924

Merged
merged 1 commit into from Mar 31, 2023
Merged

Fix update CLI #1924

merged 1 commit into from Mar 31, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 31, 2023

The ostensible suggestion in #1920 (comment) appears to have caused

setPctInPrep
------------

ERROR: something went wrong in target "setPctInPrep" : "No line matched in the file \"/tmp/updatecli/github/jenkinsci/bom/prep.sh\" for the pattern \"^pct_version=(.*)\""

Pipeline "Bump `plugin-compat-tester`" failed
Skipping due to:
	targets stage:	"something went wrong during target execution"

thereby making it a non-suggestion. This PR restores my original PR before the non-suggestion was made.

@MarkEWaite MarkEWaite merged commit b14a29e into jenkinsci:master Mar 31, 2023
1 of 2 checks passed
@MarkEWaite MarkEWaite added internal chore Reduces future maintenance and removed internal labels Mar 31, 2023
@basil basil deleted the suggestion branch March 31, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces future maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basil @MarkEWaite