Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups to #1918 #1923

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fixups to #1918 #1923

merged 1 commit into from
Mar 31, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 31, 2023 •
edited

@basil basil marked this pull request as ready for review March 31, 2023 16:35
MarkEWaite
MarkEWaite approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

OK with you if I merge without waiting for the CI process to complete?

@basil
Copy link
Member Author

basil commented Mar 31, 2023

Yes, the currently running build has exercised every line of code that I changed in this PR, so it is fine.

@MarkEWaite MarkEWaite merged commit 6a6a354 into jenkinsci:master Mar 31, 2023
6 checks passed
@MarkEWaite MarkEWaite added internal chore Reduces future maintenance and removed internal labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces future maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basil @MarkEWaite