Collect Launchable results from both Surefire and Failsafe #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Mar 31, 2023
| @@ -15,7 +15,7 @@ def mavenEnv(Map params = [:], Closure body) { | |||
| body() | |||
| } | |||
| } | |||
| if (junit(testResults: '**/target/*-reports/TEST-*.xml').failCount > 0) { | |||
| if (junit(testResults: '**/target/surefire-reports/TEST-*.xml,**/target/failsafe-reports/TEST-*.xml').failCount > 0) { | |||
There was a problem hiding this comment.
Being more explicit that these are the only two supported test runners (for example, we do not support TestNG), and also matching the CloudBees-internal version of this code for consistency.
| @@ -78,7 +78,7 @@ lines.each {line -> | |||
| sh 'mv megawar-$LINE.war megawar.war && bash pct.sh' | |||
| } | |||
| def launchableSession = readFile("launchable-session-${line}.txt").trim() | |||
| launchable("record tests --session ${launchableSession} maven './**/target/surefire-reports'") // TODO add failsafe reports | |||
| launchable("record tests --session ${launchableSession} maven './**/target/surefire-reports' './**/target/failsafe-reports'") | |||
There was a problem hiding this comment.
The Launchable CLI Maven test recorder implicitly adds TEST-*.xml as a suffix, so it is not needed here. It does not support comma-separated Ant-style globbing, but it does support multiple source roots as space-separated positional arguments.
MarkEWaite
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was rushing too quickly yesterday to bother with this, so fixing this leftover TODO today. I tested this successfully in:
https://ci.jenkins.io/job/Tools/job/bom/job/PR-1922/2/