Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily exclude DigitalOcean artifact caching proxy provider #1921

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Mar 31, 2023

As infra.withArtifactCachingProxy accepts a boolean since jenkins-infra/pipeline-library#615, this PR excludes the DigitalOcean ACP provider while working on jenkins-infra/helpdesk#3481
The AWS provider isn't concerned by the issue and is working as intended.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • [N/A] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherve lemeurherve marked this pull request as ready for review March 31, 2023 09:14
@lemeurherve
Copy link
Member Author

lemeurherve commented Mar 31, 2023

Replayed the build so I could have one with my modifications, it's not using the ACP when running from a DigitalOcean agent, LGTM.

(I've stopped the build as there is no need to waste resources on a full build to check this modification)

Logs:
 Started by user hlemeur
 Replayed #1
09:08:50  Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org)
 Connecting to https://api.github.com to check permissions of obtain list of lemeurherve for jenkinsci/bom
 Loading trusted files from base branch master at 67d3cdada817597716a682a772f4f0ff9d409354 rather than 44d3e86c270ee29c745d886c4c2900c7a066e6f0
 Obtained Jenkinsfile from 67d3cdada817597716a682a772f4f0ff9d409354
 ‘Jenkinsfile’ has been modified in an untrusted revision
 Loading library pipeline-library@master
 Library pipeline-library@master is cached. Copying from home.
 [Pipeline] Start of Pipeline
 [Pipeline] properties
 [Pipeline] stage
 [Pipeline] { (prep)
 [Pipeline] retry
 [Pipeline] {
 [Pipeline] echo
 Attempt 1 of 3
 [Pipeline] node
 Agent jnlp-maven-11-f9c5c is provisioned from template jnlp-maven-11
 ---
 apiVersion: "v1"
 kind: "Pod"
 metadata:
   labels:
     jenkins: "slave"
     jenkins/label-digest: "25a08295458738d4af47a3e71f274bebae57766b"
     jenkins/label: "container_kubernetes_doks_maven-11_jdk11"
   name: "jnlp-maven-11-f9c5c"
   namespace: "jenkins-agents"
 spec:
   containers:
   - command:
     - "/usr/local/bin/jenkins-agent"
     env:
     - name: "JENKINS_PROTOCOLS"
       value: "JNLP4-connect"
     - name: "PATH"
       value: "/opt/jdk-11/bin:/home/jenkins/.asdf/shims:/home/jenkins/.asdf/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin"
     - name: "JENKINS_SECRET"
       value: "********"
     - name: "JENKINS_AGENT_NAME"
       value: "jnlp-maven-11-f9c5c"
     - name: "ARTIFACT_CACHING_PROXY_PROVIDER"
       value: "do"
     - name: "JAVA_HOME"
       value: "/opt/jdk-11"
     - name: "JENKINS_DIRECT_CONNECTION"
       value: "ci.jenkins.io:50000"
     - name: "JENKINS_INSTANCE_IDENTITY"
       value: "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAp2xQ1s5zapp2zKL5N7SwgJs7RUnim3p48+erpM1i/2JMNnmnl7wl0RsM6USpNGSj4YGxCUMz7f7sl4xePd55DyrpqAEQGozK50jTxCRw9KA6n2ko/lUy7vkIhaT1r+3OA/goNXE3/Ov/d7lRorUKdukk561kGlSHN2QwzipHKYSWIcL/apcP+OMWS6K2sDm5ik7EtQmnaEy0C7a/Xn1i0Zm77NW8ARMhP0r8EMQ1lxZTCcarO1+4Vw/fEqkyNGh3dEykVlHIMhkptQ1ws7/rsKfjH7CAJ6L6b2rs8casoig0h7xGKsSvaxAD7S0Xo9YIzmduRsOrnsoeEK0d74BKqwIDAQAB"
     - name: "JENKINS_NAME"
       value: "jnlp-maven-11-f9c5c"
     - name: "JENKINS_AGENT_WORKDIR"
       value: "/home/jenkins/agent"
     - name: "JENKINS_JAVA_OPTS"
       value: "-XX:+PrintCommandLineFlags"
     - name: "JENKINS_JAVA_BIN"
       value: "/opt/jdk-11/bin/java"
     image: "jenkinsciinfra/jenkins-agent-ubuntu-20.04@sha256:cbdc2c722d4a5572410f5caa607c3f3624293aa6247a95ba358819117f179b22"
     imagePullPolicy: "IfNotPresent"
     name: "jnlp"
     resources:
       limits:
         memory: "8G"
         cpu: "4"
       requests:
         memory: "8G"
         cpu: "4"
     tty: false
     volumeMounts:
     - mountPath: "/home/jenkins/agent"
       name: "workspace-volume"
       readOnly: false
     workingDir: "/home/jenkins/agent"
   imagePullSecrets:
   - name: "dockerhub-credential"
   nodeSelector:
     kubernetes.io/os: "linux"
   restartPolicy: "Never"
   volumes:
   - emptyDir:
       medium: ""
     name: "workspace-volume"
 
 Running on jnlp-maven-11-f9c5c in /home/jenkins/agent/workspace/Tools_bom_PR-1921
 [Pipeline] {
 [Pipeline] timeout
 Timeout set to expire in 2 hr 0 min
 [Pipeline] {
 [Pipeline] sh
 + mvn -version
 Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
 Maven home: /usr/share/apache-maven-3.9.0
 Java version: 11.0.18, vendor: Eclipse Adoptium, runtime: /opt/jdk-11
 Default locale: en_US, platform encoding: UTF-8
 OS name: "linux", version: "5.10.0-0.deb10.17-amd64", arch: "amd64", family: "unix"
 [Pipeline] withEnv
 [Pipeline] {
 [Pipeline] checkout
 using credential app-ci.jenkins.io
 Cloning the remote Git repository
 Cloning with configured refspecs honoured and without tags
  > JGit fetch # timeout=10
 remote: Enumerating objects
 remote: Counting objects
 remote: Compressing objects
 Receiving objects
 Resolving deltas
 Updating references
 Fetching without tags
 Checking out Revision 44d3e86c270ee29c745d886c4c2900c7a066e6f0 (PR-1921)
  > JGit fetch # timeout=10
 Commit message: "Temporarily exclude DigitalOcean artifact caching proxy provider"
 [GitHub Checks] GitHub check (name: Jenkins, status: in_progress) has been published.
 using credential app-ci.jenkins.io
 using credential app-ci.jenkins.io
 [GitCheckoutListener] Recording commits of 'git https://github.com/jenkinsci/bom.git'
 [GitCheckoutListener] Found previous build 'Tools/bom/PR-1921 #1' that contains recorded Git commits
 [GitCheckoutListener] -> Starting recording of new commits since '44d3e86'
 [GitCheckoutListener] -> Single parent commit found - branch is already descendant of target branch head
 [GitCheckoutListener] -> Using head commit '44d3e86' as starting point
 [GitCheckoutListener] -> No new commits found
 [GitCheckoutListener] -> Git commit decorator successfully obtained 'hudson.plugins.git.browser.GithubWeb@7c6c6440' to render commit links
 [Pipeline] withEnv
 [Pipeline] {
 [Pipeline] withCredentials
 Masking supported pattern matches of $GITHUB_APP or $GITHUB_OAUTH
 [Pipeline] {
 [Pipeline] sh
 + bash prep.sh
 ++ dirname prep.sh
 + cd .
 + MVN='mvn -B -ntp'
 + [[ -n '' ]]
 + mvn -B -ntp clean install -Dset.changelist
 [INFO] Setting: -Dchangelist=1963.v44d3e86c270e -DscmTag=44d3e86c270ee29c745d886c4c2900c7a066e6f0
 [INFO] Setting: -DgitHubRepo=lemeurherve/bom
 [INFO] Scanning for projects...

@lemeurherve lemeurherve requested a review from a team March 31, 2023 12:08
@MarkEWaite MarkEWaite merged commit d3e7d99 into jenkinsci:master Mar 31, 2023
1 of 2 checks passed
@lemeurherve lemeurherve deleted the patch-2 branch March 31, 2023 13:15
@MarkEWaite MarkEWaite added internal chore Reduces future maintenance and removed internal labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants