Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to jenkinsci/plugin-compat-tester#505 #1908

Merged
merged 2 commits into from Mar 30, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 27, 2023

Adapt to jenkinsci/plugin-compat-tester#505 by:

  • Upgrading PCT to the latest release
  • Removing -DoverrideWarAdditions=true which has now been removed from Maven HPI plugin
  • Excluding org.jenkinsci.plugins.matrixauth.integrations.casc.ImportTest because Switch JCasC test to RealJenkinsRule matrix-auth-plugin#136 still has not been merged and released

Closes #1912

@basil
Copy link
Member Author

basil commented Mar 28, 2023

checking to see what is left for this task.

Not a whole lot, as it turns out: just jenkinsci/maven-hpi-plugin#461 (and therefore jenkinsci/plugin-compat-tester#505) from the Jenkins side, based on my preliminary testing. I will run it through the ringer in this next build. The above two PRs will require testing from "the other consumer."

@basil
Copy link
Member Author

basil commented Mar 28, 2023

Pretty decent run overall, just 4 failures:

  • org.jenkinsci.plugins.matrixauth.integrations.casc.ImportTest.should_support_configuration_as_code
  • org.jenkinsci.plugins.matrixauth.integrations.casc.ImportTest.should_support_configuration_as_code_ambiguous_format
  • org.jenkinsci.plugins.workflow.job.WorkflowRunRestartTest.interruptedWhileStartingMaxSurvivability
  • org.jenkinsci.plugins.workflow.job.WorkflowRunRestartTest.interruptedWhileStartingPerformanceOptimized

The first two are our old friend jenkinsci/matrix-auth-plugin#133.

@basil basil changed the title Testing the removal of overrideWarAdditions Adapt to jenkinsci/plugin-compat-tester#505 Mar 30, 2023
@basil basil marked this pull request as ready for review March 30, 2023 04:57
@basil
Copy link
Member Author

basil commented Mar 30, 2023

The only failure in https://ci.jenkins.io/job/Tools/job/bom/job/PR-1908/11/ was a flake regarding DNS resolution of github.com. Otherwise all tests passed.

@jenkinsci/bom-developers I require a merge of this for my ongoing PCT work.

@jglick jglick enabled auto-merge (squash) March 30, 2023 15:20
@MarkEWaite
Copy link
Contributor

I think that the DNS resolution failure in the test should not block the merge of this pull request. Merging and accepting that if there is a surprise in that merge, we will revert it.

@MarkEWaite MarkEWaite merged commit b9dfa1d into jenkinsci:master Mar 30, 2023
57 of 58 checks passed
@basil basil deleted the overrideWarAdditions branch March 30, 2023 18:35
lemeurherve pushed a commit to lemeurherve/bom that referenced this pull request Mar 31, 2023
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@MarkEWaite MarkEWaite added dependencies Pull requests that update a dependency file chore Reduces future maintenance and removed dependencies Pull requests that update a dependency file labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants