Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update jx-changelog and jx boot version #107

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

tomhobson
Copy link
Contributor

Just ensuring this is up to date and is a first class citizen

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rawlingsj
Copy link
Contributor

/approve

@tomhobson
Copy link
Contributor Author

/approve

as @rawlingsj approved and I trust his judgement

@jenkins-x-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj, tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 8d4c3f9 into main Apr 12, 2023
1 check passed
@vbehar
Copy link
Collaborator

vbehar commented Apr 12, 2023

/approve

as @rawlingsj approved and I trust his judgement

who is @rawlingsj ? never heard of him ;-) but good to know he's still alive !! and not too busy building container images without CVE

@rawlingsj
Copy link
Contributor

who is @rawlingsj ? never heard of him ;-) but good to know he's still alive !! and not too busy building container images without CVE

lol - still alive indeed :) hope everyone is doing well. Saw this on an email notification so thought I'd try to help nudge along. No worries about the owners list, to be expected. I was going to suggest using a chainguard image rather than alpine ;) but maybe save that for another day. Keep rocking the Jenkins X community!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants