Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our GHA using deprecated set-output #3176

Closed
lemeurherve opened this issue Oct 14, 2022 · 3 comments
Closed

Upgrade our GHA using deprecated set-output #3176

lemeurherve opened this issue Oct 14, 2022 · 3 comments
Assignees
Labels

Comments

@lemeurherve
Copy link
Member

lemeurherve commented Oct 14, 2022

Service(s)

GitHub

Summary

The set-output command is deprecated and will be disabled soon.
We have to upgrade jenkins-infra & jenkinsci concerned GitHub Actions to use Environment Files, as explained in the announcement: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Reproduction steps

No response

@lemeurherve lemeurherve added the triage Incoming issues that need review label Oct 14, 2022
@lemeurherve lemeurherve removed the triage Incoming issues that need review label Oct 14, 2022
@lemeurherve lemeurherve added this to the infra-team-sync-next milestone Oct 14, 2022
@lemeurherve lemeurherve changed the title Update GHA using deprecated set-output Upgrade our GHA using deprecated set-output Oct 14, 2022
@NotMyFault NotMyFault self-assigned this Oct 15, 2022
@dduportal dduportal assigned dduportal and lemeurherve and unassigned dduportal Oct 18, 2022
@lemeurherve
Copy link
Member Author

@NotMyFault many thanks for all these PRs ❤️

FTR, I had to revert one of them.
I found a potential fix to avoid error with multi-lines body, see the code block of this comment

@NotMyFault
Copy link
Member

NotMyFault commented Oct 20, 2022

I'll go ahead and close this issue. All PRs needed to upgrade workflows have been created and are merged to a good extent, the CD actions have been released and will be picked up by dependabot to update the reusable workflow repository.

Additionally, PRs outside of Jenkins that I created (e.g., release-drafter, label PR conflicts) are about to be merged and released, which prepares core repositories for the forthcoming deprecations.

@lemeurherve
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants