Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove totals in profile table properly #9186

Merged
merged 2 commits into from
Dec 18, 2022

Conversation

ashmaroli
Copy link
Member

  • This is a 馃悰 bug fix.

Summary

In #9039 I proposed to remove the TOTALS row but there were remnants that continued to generate and render info.
The current pull request removes all of such remnants.

Notes

  • Consider backporting this to the 4.3-stable branch.

@ashmaroli ashmaroli added fix backport-candidate Consider for merge into an older stable branch labels Nov 17, 2022
@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 82bb271 into jekyll:master Dec 18, 2022
@jekyllbot jekyllbot added the bug label Dec 18, 2022
@ashmaroli ashmaroli deleted the remove-profile-table-totals branch December 18, 2022 13:14
jekyllbot added a commit that referenced this pull request Dec 18, 2022
github-actions bot pushed a commit that referenced this pull request Dec 18, 2022
Ashwin Maroli: Remove totals in profile table properly (#9186)

Merge pull request 9186
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Jan 15, 2023
Remove totals in profile table properly
This backports 82bb271 to 4.3-stable
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Jan 15, 2023
ashmaroli added a commit that referenced this pull request Jan 16, 2023
ashmaroli added a commit that referenced this pull request Jan 16, 2023
@jekyll jekyll locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-candidate Consider for merge into an older stable branch bug fix frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants