Update rubocop from 1.12 to 1.18 and min ruby from 2.4 to 2.5 #8741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Jul 22, 2021
|
@jekyll: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Jul 22, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
Andrew Davis: Update rubocop from 1.12 to 1.18 and min ruby from 2.4 to 2.5 (#8741) Merge pull request 8741
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 馃敤 code refactoring.
Summary
This pull request does 3 related things:
Locally 'script/cibuild' gives this a clean bill of health.
Context
This will resolve multiple open issues.
Closes #8732
Closes #8726
Closes #8721
Closes #8720