table: RenderTSV to render in tab-separated-values format

[rafiramadhana]

Proposed Changes

• Add RenderTSV() string to Writer interface
• Add RenderTSV() implementation

Fixes #276 .

@jedib0t @dinhani

[coveralls]

Pull Request Test Coverage Report for Build 6409214047

• 50 of 50 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 5994588594:	0.0%
Covered Lines:	3361
Relevant Lines:	3361

---

💛 - Coveralls

[jedib0t]

Hey @rafiramadhana thanks a lot for contributing this feature. Code looks good, but I have one concern. I believe that columns in TSV format are not allowed to have \t and \n characters as it will break formatting. Can you figure out the best way to deal with them?

One option I'm thinking of is replacing \t with \\t and \n with \\n so that the reader can interpret it correctly, but I don't know if that is what is usually done.

[jedib0t]

@rafiramadhana It looks like you can double-quote columns which contain \t and \n. For example:

CSV:

"a","b	c","d
e"

TSV:

a	"b	c"	"d
e"

Can you please make this change in the logic?

	if strings.ContainsAny(col, "\t\n") {
		out.WriteString(fmt.Sprintf("\"%s\"", col))
	} else {
		out.WriteString(col)
	}

[rafiramadhana]

I believe that columns in TSV format are not allowed to have \t and \n characters as it will break formatting.

Yes, that is correct as mentioned in Wikipedia

Sry, I haven't implement it because I rarely use a TSV

@rafiramadhana It looks like you can double-quote columns which contain \t and \n.

Agree, I think we can start with this implementation of adding double-quote

[rafiramadhana]

@rafiramadhana It looks like you can double-quote columns which contain \t and \n.

Do we need to escape the double-quote if the columns have double-quote?

asd"fgh    qwe    zxc

"asd""fgh"   qwe   zxc

This is similar with what is done in CSV (rfc4180)

[jedib0t]

@rafiramadhana It looks like you can double-quote columns which contain \t and \n.

Do we need to escape the double-quote if the columns have double-quote?

asd"fgh    qwe    zxc

"asd""fgh"   qwe   zxc

This is similar with what is done in CSV (rfc4180)

I'm not sure what the spec calls for. But pasting "asd""fgh" qwe zxc into Excel made it come out right. So I think you are on the right track. Let's go with this approach for now.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[rafiramadhana]

@jedib0t It looks like \t gets replaced by " " (4 spaces) in render_init.go#46

So, that's why I'm adding strings.Contains(col, " ") here

[jedib0t]

Ok I'll have to refactor the original function. This may not be ideal behavior for the end-user.

[jedib0t]

Thanks @rafiramadhana for your contribution. Will cut a tag with this fix in a day or two.

[jedib0t]

Tag with this feature: https://github.com/jedib0t/go-pretty/releases/tag/v6.4.8